Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plot ref map scores #55

Merged
merged 2 commits into from
Jul 13, 2023
Merged

Plot ref map scores #55

merged 2 commits into from
Jul 13, 2023

Conversation

micahpf
Copy link
Collaborator

@micahpf micahpf commented Jul 12, 2023

Starting on some the tasks in #51

  • Fixed geom_text labels overlapping with points
  • Changed legend key to be less busy
  • Added "clip=off" to allow text to extend off plot area if necessary

I also changed the function name to be a little more concise. What do you think @derrik-gratz ? I'm totally open to other names/reverting it.

@micahpf micahpf requested a review from derrik-gratz July 12, 2023 16:39
@derrik-gratz
Copy link
Contributor

I prefer the new name

@derrik-gratz derrik-gratz merged commit e0544e4 into main Jul 13, 2023
@derrik-gratz
Copy link
Contributor

Actually, I think we need to patch this cause the cluster order isn't being preserved. I think adding to the cluster id with paste is making it a character, so it loses the factor ordering. I'm going to see if there's a gtools::mixedsort solution

derrik-gratz added a commit that referenced this pull request Jul 13, 2023
see comment in #55 about sorting
@micahpf micahpf deleted the plotRefMapScores branch August 17, 2023 19:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants