filter out carriage returns for quasiquotes

[gbwey]

There is a consistency problem when handling carriage returns across Shakespeare and Shelly.
In windows, 'st' returns \r\n but 'textFile' returns \n.

Shelly.readfile returns \r\n but Data.Text.IO.readFile retuns \n. I will add a pull request for Shelly as gregwebs/Shelly.hs#44

(interpolated-string-perl6 'q' and 'qc' return \n only)

I think most consistent behavior is to just drop the '\r' across the board when reading and leave the writing the way it is. This is consistent with Data.Text.IO readFile writeFile.

https://gist.github.com/gbwey/6833805
from the above gist: this is what we have now:
*Test6> main
120 13 10 121 :st
120 10 121 :interpolated string perl6
120 13 13 10 121 :Shelly.writefile st as abc then Shelly.readfile
120 10 10 121 :T.readFile abc
120 10 10 121 :textFile abc

120 13 10 121 :Shelly.readfile ab
120 10 121 :T.readFile ab
120 10 121 :textFile ab

and after the changes for the two pull requests this is the result

*Test6> main
120 10 121 :st
120 10 121 :interpolated string perl6
120 10 121 :Shelly.writefile st as abc then Shelly.readfile
120 10 121 :T.readFile abc
120 10 121 :textFile abc

120 10 121 :Shelly.readfile ab
120 10 121 :T.readFile ab
120 10 121 :textFile ab

Thanks,
Grant

[gregwebs]

awesome, thanks!

The only thing we would change is to only run the filter on the Windows platform so that it doesn't slow down unix.
I am going to ask about this issue on the ghc mail list also.

[gbwey]

It might also be useful on unix if someone ftps a file from windows without
converting the cr/lf, but realistically I am not sure how often that would
happen.
Grant

On Fri, Oct 4, 2013 at 7:19 PM, Greg Weber [email protected] wrote:

awesome, thanks!

The only thing we would change is to only run the filter on the Windows
platform so that it doesn't slow down unix.
I am going to ask about this issue on the ghc mail list also.

—
Reply to this email directly or view it on GitHubhttps://github.com//pull/113#issuecomment-25736576
.

[gregwebs]

true, we only ever need to strip the carriage return on Windows for the quasi-quote, but we should probably always strip files

[gregwebs]

technically we should probably replace "\r\n" with "\n" or integrate this into our line-breaking function. However I don't see the use case for a lone "\r" in shakespeare.

[gbwey]

I am in favour of eliminating \r as early in the code as possible so no one
ever has to deal with this again. I agree \r doesn't contribute anything
and doesn't have meaning by itself.

On Sun, Oct 6, 2013 at 10:26 AM, Greg Weber [email protected]:

technically we should probably replace "\r\n" with "\n" or integrate this
into our line-breaking function. However I don't see the use case for a
lone "\r" in shakespeare.

—
Reply to this email directly or view it on GitHubhttps://github.com//pull/113#issuecomment-25768925
.

[gregwebs]

Thanks, I will add the windows flag. I am too lazy to fix GHC

[gbwey]

That great. Thanks!

On Wed, Oct 23, 2013 at 1:44 PM, Greg Weber [email protected]:

Merged #113 #113.

—
Reply to this email directly or view it on GitHubhttps://github.com//pull/113
.