Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(contract): remove deprecated verifyBatchInclusion from AlignedLayerServiceManager.sol #1762

Open
wants to merge 3 commits into
base: staging
Choose a base branch
from
Open

fix(contract): remove deprecated verifyBatchInclusion from AlignedLayerServiceManager.sol #1762

wants to merge 3 commits into from

Conversation

uri-99
Copy link
Contributor

@uri-99 uri-99 commented Jan 20, 2025 •
edited
Loading

Remove deprecated verifyBatchInclusion

Description

We remove the old and deprecated verifyBatchInclusion function from AlignedLayerServiceManager.sol , to avoid user confusion.

Type of change

Please delete options that are not relevant.

  • New feature
  • Bug fix
  • Optimization
  • Refactor

Checklist

  • “Hotfix” to testnet, everything else to staging
  • Linked to Github Issue
  • This change depends on code or research by an external entity
    • Acknowledgements were updated to give credit
  • Unit tests added
  • This change requires new documentation.
    • Documentation has been added/updated.
  • This change is an Optimization
    • Benchmarks added/run
  • Has a known issue
  • If your PR changes the Operator compatibility (Ex: Upgrade prover versions)
    • This PR adds compatibility for operator for both versions and do not change batcher/docs/examples
    • This PR updates batcher and docs/examples to the newer version. This requires the operator are already updated to be compatible

@uri-99 uri-99 self-assigned this Jan 20, 2025
@uri-99 uri-99 linked an issue Jan 20, 2025 that may be closed by this pull request
fix(contract): remove deprecated verifyBatchInclusion from AlignedLayerServiceManager.sol #1757
Open
@uri-99 uri-99 changed the base branch from testnet to staging January 20, 2025 18:27
@uri-99 uri-99 changed the title fix(contract): remove deprecated verifybatchinclusion from alignedlayerservicemanagersol fix(contract): remove deprecated verifyBatchInclusion from AlignedLayerServiceManager.sol Jan 20, 2025
@uri-99 uri-99 mentioned this pull request Jan 22, 2025
Closed
18 tasks
JuArce
JuArce requested changes Jan 22, 2025
View reviewed changes
Copy link
Collaborator

@JuArce JuArce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is missing to update the anvil state

examples/verify/src/VerifyBatchInclusionCaller.sol
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is missing to udpdate the README with a new contract address for the example

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JuArce JuArce JuArce requested changes

Requested changes must be addressed to merge this pull request.

Assignees

@uri-99 uri-99

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

fix(contract): remove deprecated verifyBatchInclusion from AlignedLayerServiceManager.sol
2 participants
@uri-99 @JuArce