WIP: Display error tracebacks when vignettes fail #2390
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hadley
commented
Jan 22, 2025
| res[i] = xfun:::handle_error( | ||
| withCallingHandlers( | ||
| if (tangle) process_tangle(group) else process_group(group), | ||
| error = function(e) { | ||
| if (progress && is.function(pb$interrupt)) pb$interrupt() | ||
| if (xfun::pkg_available('rlang', '1.0.0')) rlang::entrace(e) | ||
|
|
||
| if (xfun::pkg_available('rlang', '1.0.0')) { |
There was a problem hiding this comment.
For vignettes, this implies that your package needs to depend on rlang. I think that's ok, but should be documented somewhere.
| # return a string to point out the current location in the doc | ||
| get_loc = function(label = '') { | ||
| paste0(current_lines(), label, sprintf(' (%s)', knit_concord$get('infile'))) | ||
| paste0(knit_concord$get('infile'), ":", current_lines(), label) |
There was a problem hiding this comment.
This uses a more standard format for file + line numbers that VS Code/Positron will autolink. I think it's still worthwhile to use cli here, so I'll explore adding that in the future.
There was a problem hiding this comment.
And cli hyperlinks don't work in R CMD check anyway, because if it did, it would open in the file in the check directory, not the current project.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recording some work so that I can come back to it later.