Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update annotations for OpenAPI and small fix #136

Merged
merged 3 commits into from
Feb 19, 2024

Conversation

nkondrashov
Copy link
Contributor

Q A
Is bugfix? ✔️?
New feature? ✔️?
Breaks BC? ❌?
Fixed issues Part of problem from yiisoft/yii-swagger#84

Copy link

what-the-diff bot commented Feb 18, 2024

PR Summary

  • Removal of OpenApi Annotations usage in ResponseDataWrapper
    The line that implies using OpenApi's Annotations mechanism was eliminated from the file ResponseDataWrapper.php.

  • Transition from OpenApi Annotations to Attributes in DebugSuccessResponse and DebugNotFoundResponse
    ABOur old approach of adding specifications via Annotations has been supplanted with a newer feature in OpenApi, Attributes, in the DebugSuccessResponse and DebugNotFoundResponse schemas.

  • Update Property Syntax in DebugSuccessResponse and DebugNotFoundResponse Schemas
    The structure, defining properties of DebugSuccessResponse and DebugNotFoundResponse schemas, was modified to fit the newer format supported by OpenApi attributes.

  • Employment of OpenApi Attributes in ResponseDataWrapper
    We've transitioned to the practice of defining API specifications using OpenAPI's Attributes inside the ResponseDataWrapper class, providing a more refined, up-to-date methodology.

Copy link

codecov bot commented Feb 18, 2024

Codecov Report

Attention: 203 lines in your changes are missing coverage. Please review.

Comparison is base (1a9ff6a) 3.56% compared to head (04d6816) 3.03%.

Files Patch % Lines
src/Debug/Controller/DebugController.php 0.00% 181 Missing ⚠️
src/Debug/Middleware/ResponseDataWrapper.php 0.00% 22 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             master    #136      +/-   ##
===========================================
- Coverage      3.56%   3.03%   -0.54%     
- Complexity      254     255       +1     
===========================================
  Files            22      22              
  Lines          1122    1320     +198     
===========================================
  Hits             40      40              
- Misses         1082    1280     +198     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@samdark samdark merged commit 3cdc35a into yiisoft:master Feb 19, 2024
12 of 17 checks passed
@samdark
Copy link
Member

samdark commented Feb 19, 2024

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants