This repository has been archived by the owner on Sep 20, 2024. It is now read-only.
updated command to install PySide==1.2.4 #6256
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…equalizer-integration
…equalizer-integration
…equalizer-integration
…gration' into feature/OP-6032_3dequalizer-integration
…equalizer-integration
…slamEzzat/OpenPype into local/aroma-integrate-3de4
Local/aroma integrate 3de4
FEAT: Create and Extract Warp Footage.
![hound[bot]](https://avatars.githubusercontent.com/in/3598?s=60&v=4){kind=small}
| patch("tde4.postQuestionRequester", patched_postQuestionRequester): # noqa: E501 | ||
| with open(exporter_path, 'r') as f: | ||
| script = f.read() | ||
| if not "import tde4" in script: |
There was a problem hiding this comment.
test for membership should be 'not in'
|
|
||
| order = pyblish.api.ExtractorOrder | ||
|
|
||
| def process(self, instance = pyblish.api.Instance): |
There was a problem hiding this comment.
unexpected spaces around keyword / parameter equals
| import six | ||
| import pyblish.api | ||
| import tde4 # noqa: F401 | ||
| from openpype.lib import import_filepath |
There was a problem hiding this comment.
'openpype.lib.import_filepath' imported but unused
|
|
||
| new_img_width, new_img_height = get_distortion_resolution(staging_dir) | ||
| overscan_width = (new_img_width / tde4.getCameraImageWidth(cam)) * 100.0 | ||
| overscan_height = (new_img_height / tde4.getCameraImageHeight(cam)) * 100.0 |
| thread.join() | ||
|
|
||
| new_img_width, new_img_height = get_distortion_resolution(staging_dir) | ||
| overscan_width = (new_img_width / tde4.getCameraImageWidth(cam)) * 100.0 |
| import tde4 # noqa: F401 | ||
| import threading | ||
| from openpype.pipeline import OptionalPyblishPluginMixin, publish | ||
| from openpype.hosts.equalizer.api.lib import run_warp4, convert_png, get_distortion_resolution |
| else: | ||
| overscan_width, overscan_height = 100, 100 | ||
| # raise PublishValidationError("You must extract the undistorted footage first to get the overscan") | ||
|
|
| overscan_width, overscan_height = overscan.values() | ||
| else: | ||
| overscan_width, overscan_height = 100, 100 | ||
| # raise PublishValidationError("You must extract the undistorted footage first to get the overscan") |
There was a problem hiding this comment.
line too long (112 > 79 characters)
trailing whitespace
| ) | ||
| from openpype.pipeline import PublishValidationError | ||
|
|
||
| @six.add_metaclass(ABCMeta) |
| Creator, | ||
| OptionalPyblishPluginMixin, | ||
| ) | ||
| from openpype.pipeline import PublishValidationError |
There was a problem hiding this comment.
'openpype.pipeline.PublishValidationError' imported but unused
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.