-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reduce submit publish job plugin filters #66
Reduce submit publish job plugin filters #66
Conversation
only required family is 'deadline.submit.publish.job' which is filled in collect job info
…-hosts-and-families-filters
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Although I think this does make sense - and I wanted to approve it. But...
Do note that this now ALSO runs over publish.hou
family where it didn't before? As such, we may need to just double check the expected behavior for this in Houdini @MustafaJafar ?
For whatever reason that particular publish has been going through this:
ayon-deadline/client/ayon_deadline/plugins/publish/global/submit_publish_cache_job.py
Line 62 in 15f60d6
families = ["publish.hou"] |
I'm quite sure that is likely broken then.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Didn't test - but changes look fine to me.
I do think it would be worth it to add a # TODO
that we should really start working towards not needing a separate publish job submitter for publish.hou
. Or maybe, create an issue for that @MustafaJafar if there isn't yet. Would really prefer to clean that up if we can and streamline it to one simpler interface alltogether.
Added TODO, agree we should look why we need separate submit plugin. The plugin was created in OpenPype on commit Issue #70 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested in AE, Maya
Changelog Description
Use single family to submit publish job.
Additional review information
The family is added in
CollectJobInfo
plugin so all current integrations should work as before this PR.Testing notes:
Resolves #65