Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce submit publish job plugin filters #66

Conversation

iLLiCiTiT
Copy link
Member

@iLLiCiTiT iLLiCiTiT commented Nov 25, 2024

Changelog Description

Use single family to submit publish job.

Additional review information

The family is added in CollectJobInfo plugin so all current integrations should work as before this PR.

Testing notes:

  1. Submit job to deadline from host of your choice.
  2. The job should be submitted.

Resolves #65

only required family is 'deadline.submit.publish.job' which is filled in collect job info
@iLLiCiTiT iLLiCiTiT requested review from BigRoy and kalisp November 25, 2024 10:57
@iLLiCiTiT iLLiCiTiT self-assigned this Nov 25, 2024
@iLLiCiTiT iLLiCiTiT added the type: enhancement Improvement of existing functionality or minor addition label Nov 25, 2024
Copy link
Contributor

@BigRoy BigRoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Although I think this does make sense - and I wanted to approve it. But...

Do note that this now ALSO runs over publish.hou family where it didn't before? As such, we may need to just double check the expected behavior for this in Houdini @MustafaJafar ?

For whatever reason that particular publish has been going through this:

instead.

I'm quite sure that is likely broken then.

@BigRoy BigRoy requested a review from MustafaJafar November 25, 2024 20:58
@iLLiCiTiT iLLiCiTiT requested a review from BigRoy November 26, 2024 09:38
Copy link
Contributor

@BigRoy BigRoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't test - but changes look fine to me.

I do think it would be worth it to add a # TODO that we should really start working towards not needing a separate publish job submitter for publish.hou. Or maybe, create an issue for that @MustafaJafar if there isn't yet. Would really prefer to clean that up if we can and streamline it to one simpler interface alltogether.

@iLLiCiTiT
Copy link
Member Author

iLLiCiTiT commented Nov 26, 2024

I do think it would be worth it to add a # TODO that we should really start working towards not needing a separate publish job submitter for publish.hou.

Added TODO, agree we should look why we need separate submit plugin. The plugin was created in OpenPype on commit 5e5db076d1795256ecf7b1cebe064651452cefaa, so the reason might be hidden behind some mystery.

Issue #70

Copy link
Member

@kalisp kalisp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested in AE, Maya

@iLLiCiTiT iLLiCiTiT merged commit de03d86 into develop Nov 26, 2024
1 check passed
@iLLiCiTiT iLLiCiTiT deleted the enhancement/65-submit-publish-job-without-hosts-and-families-filters branch November 26, 2024 10:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement Improvement of existing functionality or minor addition
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Submit Publish job without hosts and families filters
3 participants