Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add --removable-device option #13

Merged

Conversation

pascaleberhard0se
Copy link

Copy to destination only if it is a removable block device. This option is
recommended when writing on SD Card or USB key to avoid involuntary
destructive operations on non-removable disks. The copy command fails when the
destination file does not exist, is not a block device or is not removable.

@pascaleberhard0se pascaleberhard0se changed the title Add removable device option Add --removable-device option Mar 24, 2024
@pascaleberhard0se pascaleberhard0se force-pushed the add-removable-device-option branch from 1e1cbdb to 29d184a Compare March 25, 2024 17:16
Copy link
Collaborator

@twoerner twoerner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please add your Signed-off-By line on all patches?

When enabled, 'bmaptool copy' writes to the destination file only if it
exists and is a removable block device.

Signed-off-by: Pascal Eberhard <[email protected]>
@pascaleberhard0se pascaleberhard0se force-pushed the add-removable-device-option branch from 29d184a to 28b787b Compare March 26, 2024 16:27
@pascaleberhard0se
Copy link
Author

Could you please add your Signed-off-By line on all patches?

Indeed, I missed one. It is fixed now, thanks.

@twoerner
Copy link
Collaborator

Indeed, I missed one. It is fixed now, thanks.

Looks great, thanks!

@twoerner twoerner merged commit db89941 into yoctoproject:main Mar 27, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants