Remove DefinitionProvider and SymbolScanner #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…he already implemented and tested go-to-definition feature for variable symbols
…nding handlers or the analyzer
…tDefinitionForDirectives as it is only referenced once
WilsonZiweiWang
force-pushed
the
Refactor-DefinitionProvider
branch
from
424fd20 to
05ed54e
Compare
idillon-sfl
approved these changes
Dec 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moved all implementations in
definitionProvidertoonDefinitionhandler.The analyzer now can do everything symbolScanner was doing.
Currently, only the definition for directives and variable symbols are tested.
Next PR will bring the rest working again and test.
The PR depends on #9merged