Implement recommended extension/server setup #200
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WilsonZiweiWang
force-pushed
the
use-recommended-extension-server-structure
branch
2 times, most recently
from
25f1bcd to
41bef55
Compare
|
Probably resolves #178 |
WilsonZiweiWang
force-pushed
the
use-recommended-extension-server-structure
branch
5 times, most recently
from
fa89e3f to
2e584a0
Compare
|
The client's README content needs to move to the root. Need to decide what to do with the existing one. |
WilsonZiweiWang
changed the title
…mple Reference: https://github.com/microsoft/vscode-extension-samples/tree/main/lsp-sample 1. extension manifest is the root's package.json 2. client and server are compiled to their own out/ 3. Paths in launch.json, main.yml, package.json,etc are updated accordingly 4. Other files such as .vscodeignore and CHANGELOG are moved to the root as well
By default, the grammar test framework need to run in the directory where the extension manifest exists, which contains the contributes for language and grammar. Since the extension manifest has been moved to root, the grammar test scripts are moved as well.
The extension manifest is now root's package.json, the README in root is then used for marketplace page. The images used in the README are also moved. Some un-used images are removed.
WilsonZiweiWang
force-pushed
the
use-recommended-extension-server-structure
branch
from
2e584a0 to
7a6c729
Compare
Now we don't need to move the static files like resources/ and wasm file around as long as the relative layout is the same for both src/ and out/. For npm package, we just package the files needed while respecting the relative layout.
deribaucourt
requested changes
Apr 18, 2024
deribaucourt
approved these changes
Apr 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
I want to get rid of this message that showed up during the execution of the script
installServerIntoExtension:Source of the deprecation message:
https://github.com/microsoft/vscode-languageserver-node/blob/0226f6cd925d279dda2b777d25c5b69518ac0035/server/bin/installServerIntoExtension#L70
Ticket: 14334
How
To implement the recommended setup in
lsp-sample:vsce packagewill need to run in root afterwards)out/Other changes to make:
launch.json,main.yml..gitignore,.vscodeignoreand.npmignore.Test results
All functionalities seem to work on my end
VSIX
npm package
What is not working
The integration tests don't seem to work. Local run and CI froze at this stage.