Fix: Stop saving all open editors when saving a bitbake file #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The default behavior of vscode is to save all open editors when a task is run. We currently run the parsing task for any bitbake file save. This means that if you have multiple bitbake files open, all of them will be saved when any one of them is saved which is not the desired behavior. This patch temporarily disables the saveBeforeRun setting when the bitbake/parseAllRecipes request is received.
WilsonZiweiWang
approved these changes
Dec 6, 2023
|
I imagine users might want to have this configurable but let's see. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The default behavior of vscode is to save all open editors when a task is run. We currently run the parsing task for any bitbake file save. This means that if you have multiple bitbake files open, all of them will be saved when any one of them is saved which is not the desired behavior.
This patch temporarily disables the saveBeforeRun setting when the bitbake/parseAllRecipes request is received.