Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Devtool support #29

Merged
merged 9 commits into from
Dec 18, 2023
Merged

Devtool support #29

merged 9 commits into from
Dec 18, 2023

Conversation

deribaucourt
Copy link
Member

Commands, views and scan for managing devtool workspaces

@deribaucourt deribaucourt mentioned this pull request Dec 8, 2023
Closed
@deribaucourt deribaucourt force-pushed the devtool branch 8 times, most recently from e9c21ca to 09c9bd1 Compare December 15, 2023 08:25
@deribaucourt
Feature: Add devtool workspaces to bitbake scan result
79a1639 
Use `devtool status` to get the list of devtool workspaces.
@deribaucourt
Ui: Rephrase some recipes related strings
410ac4d 
Preparing for new devtool commands, improve clarity or genericity of
some presented UI elements.
@deribaucourt
Feature: Add devtool workspaces view
9cdaa77 
Present the scan results for devtool workspaces in a new view that will
allow manipulating them.
@deribaucourt
Feature: Add basic devtool commands
619bb5e 
Add commands to modify, update, reset and open devtool workspaces.
@deribaucourt
Feature: Open bbappend file after devtool update-recipe
0d39171
@deribaucourt
Refactor: Remove bitBakeProjectScanner singleton
2a39579 
There is no necessity for a singleton here. It makes the code harder
to test.
@deribaucourt
Test: Add unit test for devtool workspaces view
7f17a67
@deribaucourt deribaucourt marked this pull request as ready for review December 15, 2023 09:28
@deribaucourt deribaucourt changed the base branch from staging to staging-next December 15, 2023 10:36
idillon-sfl
idillon-sfl approved these changes Dec 16, 2023
View reviewed changes
Copy link
Member

@idillon-sfl idillon-sfl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not exactly sure how this functionality works, but I could not find any obvious error in the code

@deribaucourt deribaucourt merged commit 1e3da0a into yoctoproject:staging-next Dec 18, 2023
1 check passed
@deribaucourt deribaucourt deleted the devtool branch December 18, 2023 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@idillon-sfl idillon-sfl idillon-sfl approved these changes

@WilsonZiweiWang WilsonZiweiWang Awaiting requested review from WilsonZiweiWang

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@deribaucourt @idillon-sfl