Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

style: improved clock screen design #237

Merged
merged 3 commits into from
Dec 9, 2023
Merged

style: improved clock screen design #237

merged 3 commits into from
Dec 9, 2023

Conversation

SuhasDissa
Copy link
Member

Before After
image image

@SuhasDissa SuhasDissa requested review from M00NJ and Bnyro December 8, 2023 17:33
@M00NJ
Copy link
Member

M00NJ commented Dec 8, 2023

Nice changes!
I think the box with the time string could use a bit more horizontal padding than on the screenshot. The font gets quite close to the edge. Maybe the same values as the M3D button.

@SuhasDissa
Merge branch 'main' into world-clock-design
0645de6 
# Conflicts:
#	app/src/main/java/com/bnyro/clock/util/TimeHelper.kt
@SuhasDissa
style: fix time text padding
93c1082
@SuhasDissa SuhasDissa merged commit b5999ba into you-apps:main Dec 9, 2023
1 check passed
@SuhasDissa SuhasDissa deleted the world-clock-design branch December 9, 2023 06:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@M00NJ M00NJ M00NJ approved these changes

@Bnyro Bnyro Bnyro approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@SuhasDissa @M00NJ @Bnyro