fix: clock list performance issues #242
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bnyro
reviewed
Dec 11, 2023
| var sortOrder by mutableStateOf( | ||
| if (sortOrderPref.isNotEmpty()) SortOrder.valueOf(sortOrderPref) else SortOrder.ALPHABETIC | ||
| ) | ||
| var sortOrder: SortOrder |
There was a problem hiding this comment.
Suggested change
| var sortOrder: SortOrder | |
| var sortOrder by lazy { | |
| val sortOrderPref = | |
| Preferences.instance.getString(Preferences.clockSortOrder, "").orEmpty() | |
| sortOrder = | |
| if (sortOrderPref.isNotEmpty()) SortOrder.valueOf(sortOrderPref) else SortOrder.ALPHABETIC | |
| updateSortOrder(sortOrder) | |
| sortOrder | |
| } |
There was a problem hiding this comment.
(That's just so that the initialization of the variable is at the place where it's created)
Bnyro
approved these changes
Dec 11, 2023
SuhasDissa
force-pushed
the
clock-performance
branch
from
c4d3d65 to
8e6305f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.