Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Visual glitch in alarm and clock lists #303

Merged
merged 1 commit into from
Feb 27, 2024

Conversation

SuhasDissa
Copy link
Member

fix #283
fix #264

@SuhasDissa SuhasDissa requested a review from Bnyro February 27, 2024 13:13
@@ -112,7 +112,7 @@ fun AlarmScreen(

}

items(alarms) {
items(items = alarms, key = { it.id }) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very neat, I didn't know this feature/argument exists. That's probably very useful at other places of some You Apps too.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't know that until today. I discovered this while trying to fix a totally different problem.

@SuhasDissa SuhasDissa merged commit 445f567 into you-apps:main Feb 27, 2024
1 check passed
@SuhasDissa SuhasDissa deleted the glitch branch March 24, 2024 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wrong time displayed when adding new cities to world clock Deleting an alarm changes which alarms are active
2 participants