Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: timer service #332

Merged
merged 1 commit into from
Apr 16, 2024
Merged

fix: timer service #332

merged 1 commit into from
Apr 16, 2024

Conversation

SuhasDissa
Copy link
Member

Worked on the timer service to hopefully make it better

  • Removed references to TimerService from the viewModel, to avoid crashes caused by static field leak
  • Moved the timer service connection to MainActivity
  • Removed the unnecessary "Timer Service" start notification.
  • Used kotlin state flow, so we can avoid managing mutable lists in both timer service and viewModel
  • Use broadcast intents to control the timer service.

@SuhasDissa SuhasDissa merged commit 6c25e97 into you-apps:main Apr 16, 2024
1 check passed
@SuhasDissa SuhasDissa deleted the timer-service branch April 28, 2024 07:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Bnyro Bnyro Bnyro approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SuhasDissa @Bnyro