-
Notifications
You must be signed in to change notification settings - Fork 407
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Install wal-g from a precompiled bin #1006
Conversation
hughcapet
commented
Jul 22, 2024
•
edited
Loading
edited
- decrease build time
- fix the problem of missing brotli compression type after upgrade to WAL-G v3 (ref. Makefile: change compilation and linking of libbrotli to optional (and off by default) wal-g/wal-g#1379)
d52b72b
to
1e162c4
Compare
d6ecdb8
to
7f51b8e
Compare
This reverts commit 7f51b8e.
Are there tests covering the check whether wal-g supports brotli ? It looks like we're relying on the fact that precompiled binaries (may have) enabled the optional brotli compression support by explicitly setting |
@macedigital Tests are currently covering our default configuration (not to use WAL-G for backup) |
I think we should add tests for supported compression algorithms in general to Spilo, as Something like: for algo in lz4 lzma brotli; do
# ... verify backups can be created and restored from $algo
done WDYT? |
depending on how fast you need this fix to be rolled out and if you want to volunteer implementing it now:) |
Could be a follow-up PR as fixing applying a fix for the missing brotli support is urgent. |
👍 |
👍 |