Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install wal-g from a precompiled bin #1006

Merged
merged 3 commits into from
Jul 23, 2024
Merged

Install wal-g from a precompiled bin #1006

merged 3 commits into from
Jul 23, 2024

Conversation

hughcapet
Copy link
Member

@hughcapet hughcapet commented Jul 22, 2024

@hughcapet hughcapet marked this pull request as ready for review July 22, 2024 22:51
@macedigital
Copy link
Member

Are there tests covering the check whether wal-g supports brotli ?

It looks like we're relying on the fact that precompiled binaries (may have) enabled the optional brotli compression support by explicitly setting USE_BROTLI=1 at build time.

@hughcapet
Copy link
Member Author

hughcapet commented Jul 23, 2024

@macedigital Tests are currently covering our default configuration (not to use WAL-G for backup)
I tested this specific setup though (see the reverted commit)

@macedigital
Copy link
Member

I think we should add tests for supported compression algorithms in general to Spilo, as lz4 or lzma might be dropped at one time in future as well. This would help detecting issues with creating or restoring from backups early.

Something like:

for algo in lz4 lzma brotli; do
  # ... verify backups can be created and restored from $algo
done

WDYT?

@hughcapet
Copy link
Member Author

hughcapet commented Jul 23, 2024

depending on how fast you need this fix to be rolled out and if you want to volunteer implementing it now:)
(this can also be a follow-up PR)

@macedigital
Copy link
Member

depending on how fast you need this fix to be rolled out and if you want to volunteer implementing it now:) (this can also be a follow-up PR)

Could be a follow-up PR as fixing applying a fix for the missing brotli support is urgent.

@macedigital
Copy link
Member

👍

@hughcapet
Copy link
Member Author

👍

@hughcapet hughcapet merged commit d12e65a into master Jul 23, 2024
4 checks passed
@hughcapet hughcapet deleted the precompiled-walg branch July 23, 2024 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants