Add toggle to enable grouping log by date/instance in s3 #941
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hughcapet
reviewed
Nov 29, 2023
|
Looks good to me |
Co-authored-by: Polina Bungina <[email protected]>
|
👍 |
1 similar comment
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective:
This pull request introduces a new feature that enhances our log file management system. It enables users to efficiently group log files based on the date stored in an S3 bucket, providing a more streamlined approach to downloading log files. With date-based log grouping, instance rotations become less of a hassle. Users no longer need to check the instance names of deleted instances when downloading log files of a specific date.
How to Use:
Users can easily enable the new feature by setting the newly introduced environment variable
LOG_GROUPED_BY_DATEtoTrue. This environment variable serves as a toggle to activate the date-based grouping functionality. By default, ifLOG_GROUPED_BY_DATEis not specified or set toFalse, the system will continue to group log files by instance ID or POD ID, ensuring backward compatibility.