Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci): fix workflow results parsing #40

Merged
merged 2 commits into from
Nov 4, 2024
Merged

Conversation

soonum
Copy link
Contributor

@soonum soonum commented Oct 31, 2024

This is done to fix benchmarks results stored in database.
Some FFT64 were referenced as FFT128 due to errors during parsing in benchmark workflow.

In addition, FFT128 results were mixed with regular FFT at parsing due to the '--name-suffix' being applied globally.
@soonum soonum requested a review from IceTDrinker October 31, 2024 14:48
@soonum soonum self-assigned this Oct 31, 2024
@cla-bot cla-bot bot added the cla-signed label Oct 31, 2024
Copy link
Member

@IceTDrinker IceTDrinker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So if I understand correctly f128 benchmarks were run and the f64 as well ?

@soonum
Copy link
Contributor Author

soonum commented Oct 31, 2024

So if I understand correctly f128 benchmarks were run and the f64 as well ?

Yes, adding the cargo feature fft128 was only additive so both f64 and f128 were run.

Adds actionlint configuration file.
Also install runner as a ubuntu user instead of root.
@soonum soonum force-pushed the dt/ci/fix_bench_parsing branch from 1c93576 to 36eb393 Compare November 4, 2024 08:37
@soonum soonum requested a review from IceTDrinker November 4, 2024 08:39
@soonum soonum merged commit 6f72e6a into main Nov 4, 2024
16 checks passed
@soonum soonum deleted the dt/ci/fix_bench_parsing branch November 4, 2024 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants