Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(gpu): fix compression bench name #1481

Merged
merged 1 commit into from
Aug 20, 2024
Merged

fix(gpu): fix compression bench name #1481

merged 1 commit into from
Aug 20, 2024

Conversation

pdroalves
Copy link
Contributor

closes: please link all relevant issues

PR content/description

Check-list:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • Relevant issues are marked as resolved/closed, related issues are linked in the description
  • Check for breaking changes (including serialization changes) and add them to commit message following the conventional commit specification

@cla-bot cla-bot bot added the cla-signed label Aug 19, 2024
@IceTDrinker
Copy link
Member

could be good to check the benchmarks run before approving/reviewing this PR (maybe only running the compression temporarily to check it works fine)

@pdroalves pdroalves force-pushed the pa/fix/bench_compress branch from ca58157 to 6606619 Compare August 19, 2024 16:54
@pdroalves
Copy link
Contributor Author

Ok, I think this needs attention from someone more familiar to integer benchmarking and slab. It seems that we need to generate parameter files in tfhe/benchmarks_parametersfor these new benchmarks, and I think these may not be the last modifications we need to do.

I will rollback to the original strategy of having all compression benchmarks on a separate file, just as the CPU does, so we fix GPU's integer benchmarking. When @agnesLeroy or @soonum are back we return to this topic and (maybe) refactor both benchmark sets.

@pdroalves pdroalves force-pushed the pa/fix/bench_compress branch from 6606619 to 33d0f7c Compare August 20, 2024 14:40
@pdroalves pdroalves requested a review from IceTDrinker August 20, 2024 15:49
@pdroalves
Copy link
Contributor Author

@pdroalves pdroalves merged commit 27a4564 into main Aug 20, 2024
91 checks passed
@pdroalves pdroalves deleted the pa/fix/bench_compress branch August 20, 2024 20:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants