New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ns/remove arch features #1858

Merged

nsarlin-zama merged 8 commits into main from ns/remove_arch_features

Dec 17, 2024

Contributor

nsarlin-zama commented Dec 9, 2024

closes: https://github.com/zama-ai/tfhe-rs-internal/issues/827

PR content/description

Removes the arch specific features: "x86_64-unix", "aarch64-unix",... Now tfhe-csprng enables the right seeders and prng automatically:

for the seeder, x86 targets are always compiled with rdseed, and unix targets will always be compiled with /dev/random support. The seeder choice will be made at runtime based on the available options
for the generator, by default a hardware implem using aesni/neon will be chosen by default. User can force the usage of the software implementation with the software_prng feature.

I think this is the closest to the previous behavior, where we already had a trait object for the seeder and a statically dispatched generator

Check-list:

Tests for the changes have been added (for bug fixes / features)
Docs have been added / updated (for bug fixes / features)
Relevant issues are marked as resolved/closed, related issues are linked in the description
Check for breaking changes (including serialization changes) and add them to commit message following the conventional commit specification

cla-bot bot added the cla-signed label

nsarlin-zama requested review from tmontaigu and IceTDrinker

December 9, 2024 17:23

nsarlin-zama force-pushed the ns/remove_arch_features branch 2 times, most recently from eceb309 to 2cd7df1 Compare

December 10, 2024 09:44

tmontaigu reviewed

View reviewed changes

tfhe/Cargo.toml Outdated Show resolved Hide resolved

tfhe/src/core_crypto/commons/math/random/activated_random_generator.rs Outdated Show resolved Hide resolved

tfhe-csprng/src/generators/aes_ctr/mod.rs Outdated Show resolved Hide resolved

IceTDrinker reviewed

View reviewed changes

tfhe-csprng/benches/benchmark.rs Outdated Show resolved Hide resolved

IceTDrinker reviewed

View reviewed changes

tfhe-csprng/examples/generate.rs Outdated Show resolved Hide resolved

IceTDrinker reviewed

View reviewed changes

tfhe/src/core_crypto/commons/math/random/activated_random_generator.rs Outdated Show resolved Hide resolved

IceTDrinker reviewed

View reviewed changes

tfhe-csprng/examples/generate.rs Outdated Show resolved Hide resolved

IceTDrinker reviewed

View reviewed changes

tfhe/src/core_crypto/commons/math/random/activated_random_generator.rs Outdated Show resolved Hide resolved

IceTDrinker reviewed

View reviewed changes

tfhe-csprng/Cargo.toml Outdated Show resolved Hide resolved

IceTDrinker reviewed

View reviewed changes

tfhe/Cargo.toml Outdated Show resolved Hide resolved

IceTDrinker reviewed

View reviewed changes

tfhe/docs/getting_started/installation.md Outdated Show resolved Hide resolved

IceTDrinker reviewed

View reviewed changes

tfhe/docs/guides/c_api.md Outdated Show resolved Hide resolved

nsarlin-zama force-pushed the ns/remove_arch_features branch from 2cd7df1 to 6f72490 Compare

December 13, 2024 14:00

nsarlin-zama requested review from tmontaigu and IceTDrinker

December 13, 2024 14:04

IceTDrinker reviewed

View reviewed changes

tfhe-csprng/benches/benchmark.rs Outdated Show resolved Hide resolved

nsarlin-zama requested a review from IceTDrinker

December 13, 2024 15:07

nsarlin-zama added 4 commits

December 16, 2024 11:46


          chore(csprng)!: remove seeder_unix feature

b5c5f71

BREAKING_CHANGE:
- The `seeder_unix` feature is no longer supported for tfhe-csprng


          chore(csprng)!: remove seeder_x86_64_rdseed feature

e5fe1d6

BREAKING_CHANGE:
- The `seeder_x86_64_rdseed` feature is no longer supported for tfhe-csprng


          chore(csprng)!: remove generator_x86_64_aesni feature

233685b

BREAKING_CHANGE:
- The `generator_x86_64_aesni` feature is no longer supported for tfhe-csprng


          chore(csprng)!: remove generator_aarch64_aes feature

ba2ba66

BREAKING_CHANGE:
- The `generator_aarch64_aes` feature is no longer supported for tfhe-csprng

nsarlin-zama force-pushed the ns/remove_arch_features branch from 69112ef to 1cec487 Compare

December 16, 2024 10:47

tmontaigu approved these changes

View reviewed changes

zama-bot added the approved label

nsarlin-zama added the m1_test label

github-actions bot removed the m1_test label


          chore(tfhe)!: remove arch specific features

61577c7

BREAKING_CHANGE:
-	The x86_64, x86_64-unix, aarch64, aarch64-unix have been removed, the target
architecture and os family are now automatically detected. A `software_prng`
feature has been added to force the use of a software implementation on older
CPUs

nsarlin-zama added 3 commits

December 16, 2024 15:52


          chore(csprng)!: moved the RandomGenerator detector into tfhe-csprng

c6f1605


          chore(doc): fix c_api setup command using removed make target

14a9e31


          chore(csprng): prepare release 0.5.0

f4e2757

nsarlin-zama force-pushed the ns/remove_arch_features branch from 1cec487 to f4e2757 Compare

December 16, 2024 14:53

zama-bot removed the approved label

nsarlin-zama added approved m1_test labels

github-actions bot removed the m1_test label

nsarlin-zama merged commit 4e2db92 into main

153 of 160 checks passed

nsarlin-zama deleted the ns/remove_arch_features branch

December 17, 2024 08:22

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved cla-signed