Am/refactor/factorize expansion code #1870
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Yes maybe this could use the Expandable trait ? |
|
This was not the goal of the PR, I let you do that on top/after if you want to |
IceTDrinker
force-pushed
the
am/refactor/factorize-expansion-code
branch
from
7d9ea48 to
6eb8cb0
Compare
mayeul-zama
approved these changes
Jan 2, 2025
IceTDrinker
force-pushed
the
am/refactor/factorize-expansion-code
branch
from
6eb8cb0 to
7216706
Compare
|
just rebased to avoid the branch getting out of sync |
|
I need some time to go over this change again and see if it's better this way (is certainly less error prone when a change needs to be applied for all lists) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: https://github.com/zama-ai/tfhe-rs-internal/issues/787
Adds sanitization for all expansion code paths
Factorize in a single function to avoid issues later, managed to make it work without it being too weird @nsarlin-zama
Maybe traits would be better, this works, I let you tweak if needed