feat(hlapi): add strings #1882
Merged
feat(hlapi): add strings #1882
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tmontaigu
force-pushed
the
tm/hlstrings
branch
3 times, most recently
from
7f541c9 to
20b34c3
Compare
tmontaigu
force-pushed
the
tm/hlstrings
branch
from
20b34c3 to
c8cf7e4
Compare
nsarlin-zama
reviewed
Jan 6, 2025
IceTDrinker
reviewed
Jan 6, 2025
IceTDrinker
reviewed
Jan 6, 2025
IceTDrinker
approved these changes
Jan 7, 2025
|
Test should have failed, the make recipe for high level tests is missing the strings feature |
then feel free to rebase and update the make target |
tmontaigu
force-pushed
the
tm/hlstrings
branch
from
c8cf7e4 to
6c327cf
Compare
nsarlin-zama
approved these changes
Jan 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.