Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(gpu): rework single carry prop to avoid using local streams #1889

Merged
merged 1 commit into from
Dec 19, 2024

Conversation

agnesLeroy
Copy link
Contributor

closes: please link all relevant issues

PR content/description

Check-list:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • Relevant issues are marked as resolved/closed, related issues are linked in the description
  • Check for breaking changes (including serialization changes) and add them to commit message following the conventional commit specification

@cla-bot cla-bot bot added the cla-signed label Dec 18, 2024
@agnesLeroy agnesLeroy marked this pull request as ready for review December 18, 2024 13:11
@agnesLeroy agnesLeroy changed the title chore(gpu): rework single carry proip to avoid using local streams chore(gpu): rework single carry prop to avoid using local streams Dec 18, 2024
@agnesLeroy
Copy link
Contributor Author

@agnesLeroy
Copy link
Contributor Author

agnesLeroy commented Dec 18, 2024

Copy link
Member

@guillermo-oyarzun guillermo-oyarzun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is change is a bit complex. Just to be extra safe, it should be verified with: add, unsigned_overflowing_add, signed_overflowing_add, unsigned_overflowing_scalar_add, just to test all combinations

@agnesLeroy
Copy link
Contributor Author

All multi-GPU tests have passed, I also ran those functions locally they were passing.

@guillermo-oyarzun
Copy link
Member

All multi-GPU tests have passed, I also ran those functions locally they were passing.

ok, then good to go!

@agnesLeroy agnesLeroy merged commit d6e4585 into main Dec 19, 2024
169 of 178 checks passed
@agnesLeroy agnesLeroy deleted the al/rework_single_carry_prop branch December 19, 2024 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants