Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(gpu): implement CUDA Graph to accelerate default classical and multibit PBS #1907

Closed
wants to merge 2 commits into from

Conversation

pdroalves
Copy link
Contributor

closes: please link all relevant issues

PR content/description

Check-list:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • Relevant issues are marked as resolved/closed, related issues are linked in the description
  • Check for breaking changes (including serialization changes) and add them to commit message following the conventional commit specification

@cla-bot cla-bot bot added the cla-signed label Dec 27, 2024
@pdroalves pdroalves requested a review from agnesLeroy December 27, 2024 18:26
@pdroalves pdroalves added 4090_bench Launch integer bench on our CI 4090 desktop 4090_test Launch test on our CI 4090 desktop labels Dec 27, 2024
@github-actions github-actions bot removed 4090_bench Launch integer bench on our CI 4090 desktop 4090_test Launch test on our CI 4090 desktop labels Dec 27, 2024
@agnesLeroy
Copy link
Contributor

Hey! Seems like the PBS test is failing 🤔 we can talk about it during the sync 🙂

…odeThreadLocal to avoid CPU multi-thread issues
@pdroalves
Copy link
Contributor Author

@agnesLeroy I was using CUDA Graphs with cudaStreamCaptureModeGlobal, which basically forbids CPU multi-threading. I replaced it by a more strict mode that records only things happening on a single stream. That seems to fix the classical PBS issue. There is still something going on with the multi-bit PBS. I will check it tomorrow.

@pdroalves pdroalves closed this Jan 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants