Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci): run user permissions check if job should run #2011

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

soonum
Copy link
Contributor

@soonum soonum commented Jan 27, 2025

A small workflow optimization by running user permissions check only if a job is supposed to run.

A small workflow optimization by running user permissions check
only if a job is supposed to run.
@soonum soonum added the ci label Jan 27, 2025
@soonum soonum requested a review from IceTDrinker January 27, 2025 17:00
@soonum soonum self-assigned this Jan 27, 2025
@cla-bot cla-bot bot added the cla-signed label Jan 27, 2025
@IceTDrinker
Copy link
Member

@soonum I'm seeing cancelled workflows even in other PRs something to investigate

e.g. https://github.com/zama-ai/tfhe-rs/actions/runs/12994186340/job/36238356440?pr=2011

Copy link
Member

@IceTDrinker IceTDrinker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks ! this will allow to more easily identify which workflow requires a manual run

@@ -148,9 +148,11 @@ jobs:
# Fail if the triggering actor is not part of Zama organization.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thinking about the aggregate file changes above, there is no outputs.any_changed that is global to avoid doing it by hand ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants