Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(integer): impl Named for compression keys #2015

Merged
merged 1 commit into from
Jan 29, 2025

Conversation

mayeul-zama
Copy link
Contributor

@mayeul-zama mayeul-zama commented Jan 29, 2025

This change is Reviewable

@IceTDrinker
Copy link
Member

conformance already done for all structs ?

Copy link
Contributor

@nsarlin-zama nsarlin-zama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! :lgtm:

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @IceTDrinker)

@mayeul-zama
Copy link
Contributor Author

mayeul-zama commented Jan 29, 2025

conformance already done for all structs ?

Not for CompressionPrivateKeys, which is probably not useful
It's done for the other types

@nsarlin-zama
Copy link
Contributor

conformance already done for all structs ?

Not for CompressionPrivateKeys, which is probably not useful It's done for the other types

Maybe for coherence we should still implement it or remove the serialize impl ?

@mayeul-zama
Copy link
Contributor Author

conformance already done for all structs ?

Not for CompressionPrivateKeys, which is probably not useful It's done for the other types

Maybe for coherence we should still implement it or remove the serialize impl ?

ClientKey also impl Named but not ParameterSetConformant

It can still be useful for using safe_deserialization without conformance and avoid some deserialization errors
IMO it's fine as is

@IceTDrinker
Copy link
Member

If it’s not too bad and we have it for client key could be worth adding the missing conformance

Copy link
Member

@IceTDrinker IceTDrinker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot !

@mayeul-zama mayeul-zama merged commit 298640a into main Jan 29, 2025
236 checks passed
@mayeul-zama mayeul-zama deleted the mz/named_compression_keys branch January 29, 2025 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants