ui: Add background color property to label

[helgemahrt]

For issue #14093 I need to be able to specify a background color on the label used for the vim mode indicator.

Release Notes:

• N/A

[maxdeviant]

@danilo-leal raised a good point: is there a reason this needs to be on the label instead of just setting a background color for the containing element?

[helgemahrt]

@danilo-leal raised a good point: is there a reason this needs to be on the label instead of just setting a background color for the containing element?

Let me preface this with saying that I'm still new to this code base. :) From what I saw, the vim status indicator is a label sitting directly on the status bar and I didn't want to change the background color of the whole status bar: https://github.com/zed-industries/zed/blob/main/crates/vim/src/mode_indicator.rs#L111 Is there another containing element? I saw that Label internally has a Div, but setting bg on the Div did not have any effect.

[maxdeviant]

@danilo-leal raised a good point: is there a reason this needs to be on the label instead of just setting a background color for the containing element?

Let me preface this with saying that I'm still new to this code base. :) From what I saw, the vim status indicator is a label sitting directly on the status bar and I didn't want to change the background color of the whole status bar: https://github.com/zed-industries/zed/blob/main/crates/vim/src/mode_indicator.rs#L111 Is there another containing element? I saw that Label internally has a Div, but setting bg on the Div did not have any effect.

We could add a wrapping div in the ModeIndicator if we need to put a background color on it.

[maxdeviant]

I'm going to close this PR out, as it seems we can achieve the results we want without modifying Label.

[helgemahrt]

Just achieved the same by using a div. Thanks, I learned something today! :)