Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show inline documentation in menu even if documentation is disabled #22137

Merged
merged 1 commit into from
Dec 17, 2024

Conversation

mrnugget
Copy link
Member

@mrnugget mrnugget commented Dec 17, 2024

This makes inline completions show up in the completion menu even if the user has set "show_completion_documentation": false in their settings, because there is no other way to show the Zeta completion.

Follow-up to #22093

Release Notes:

  • N/A

This makes inline completions show up in the completion menu even if the
user has set `"show_completion_documentation": false` in their settings,
because there is no other way to show the Zeta completion.

Co-authored-by: Danilo <[email protected]>
@cla-bot cla-bot bot added the cla-signed The user has signed the Contributor License Agreement label Dec 17, 2024
@mrnugget mrnugget merged commit 228c89a into main Dec 17, 2024
9 of 10 checks passed
@mrnugget mrnugget deleted the zeta-show-if-doc-disabled branch December 17, 2024 13:52
helgemahrt pushed a commit to helgemahrt/zed that referenced this pull request Dec 18, 2024
…ed-industries#22137)

This makes inline completions show up in the completion menu even if the
user has set `"show_completion_documentation": false` in their settings,
because there is no other way to show the Zeta completion.

Follow-up to zed-industries#22093

Release Notes:

- N/A

Co-authored-by: Danilo <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed The user has signed the Contributor License Agreement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant