zed: Fix formatting in workspace initialization #22152
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cla-bot
bot
added
the
cla-signed
Base automatically changed from
marshall/assistant2-allow-assistant1
to
main
December 17, 2024 19:24
maxdeviant
force-pushed
the
marshall/fix-formatting-in-workspace-initialization
branch
from
d94da9c to
64173dd
Compare
maxdeviant
deleted the
marshall/fix-formatting-in-workspace-initialization
branch
helgemahrt
pushed a commit
to helgemahrt/zed
that referenced
this pull request
Dec 18, 2024
This PR fixes some formatting issues in the workspace initialization code that stemmed from certain constructs causing `rustfmt` to bail out of the formatting. The bulk of the content of `initialize_workspace` has been factored out into functions, as having nested closures within closures seems to be the primary cause of `rustfmt` being unhappy. Release Notes: - N/A
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes some formatting issues in the workspace initialization code that stemmed from certain constructs causing
rustfmtto bail out of the formatting.The bulk of the content of
initialize_workspacehas been factored out into functions, as having nested closures within closures seems to be the primary cause ofrustfmtbeing unhappy.Release Notes: