Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make TextSize::rems take AppContext instead of WindowContext #23220

Merged
merged 1 commit into from
Jan 16, 2025
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions crates/ui/src/styles/typography.rs
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
use gpui::{
div, rems, IntoElement, ParentElement, Rems, RenderOnce, SharedString, Styled, WindowContext,
div, rems, AppContext, IntoElement, ParentElement, Rems, RenderOnce, SharedString, Styled,
WindowContext,
};
use settings::Settings;
use theme::{ActiveTheme, ThemeSettings};
Expand Down Expand Up @@ -130,7 +131,7 @@ pub enum TextSize {

impl TextSize {
/// Returns the text size in rems.
pub fn rems(self, cx: &WindowContext) -> Rems {
pub fn rems(self, cx: &AppContext) -> Rems {
let theme_settings = ThemeSettings::get_global(cx);

match self {
Expand Down
Loading