Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code cleanups #43

Merged
merged 10 commits into from
Jan 17, 2025
Merged

Code cleanups #43

merged 10 commits into from
Jan 17, 2025

Conversation

d3zd3z
Copy link
Collaborator

@d3zd3z d3zd3z commented Dec 13, 2024

This contains various code cleanups suggested by rustfmt. This is its own PR as these changes are unlikely to have any semantic difference, and should be easier to review. Suggestions from clippy will be in another change.

Run `cargo fmt` with the default rules.  This gives us a baseline to be
able to require properly formatted code for future changes.

Signed-off-by: David Brown <[email protected]>
Format code with default rules.  Provides a baseline for upcoming work
to be able to require properly formatted code.

Signed-off-by: David Brown <[email protected]>
Format the source according to the default rules.  This provides a
baseline for future changes to require well-formatted source.

Signed-off-by: David Brown <[email protected]>
Format the source according to the default rules. This provides a
baseline for future changes to require well-formatted source.

Signed-off-by: David Brown <[email protected]>
Format the source according to the default rules. This provides a
baseline for future changes to require well-formatted source.

Signed-off-by: David Brown <[email protected]>
Format the source according to the default rules. This provides a
baseline for future changes to require well-formatted source.

Signed-off-by: David Brown <[email protected]>
Format the source according to the default rules. This provides a
baseline for future changes to require well-formatted source.

Signed-off-by: David Brown <[email protected]>
Format the source according to the default rules. This provides a
baseline for future changes to require well-formatted source.

Signed-off-by: David Brown <[email protected]>
@d3zd3z d3zd3z marked this pull request as ready for review January 16, 2025 22:49
@d3zd3z d3zd3z requested review from teburd, cfriedt and ithinuel January 16, 2025 22:49
@d3zd3z d3zd3z mentioned this pull request Jan 17, 2025
Copy link

@theotherjimmy theotherjimmy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I trust rustfmt. I also don't see anything out of whack.

Format the source according to the default rules. This provides a
baseline for future changes to require well-formatted source.

Signed-off-by: David Brown <[email protected]>
Copy link
Collaborator

@teburd teburd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks fine to me, clippy and rustfmt are great tools to keep the code uniform in feel and look for sure, nice!

Ensure the formatting is up to date before going through the rest of the
build.

Signed-off-by: David Brown <[email protected]>
@d3zd3z d3zd3z merged commit afc8bc1 into main Jan 17, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants