samples: usb: dfu: Exclude all Atmel SAM0 #84534
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The dfu sample filter seems not to work. It should select only boards when slot0_partition and slot1_partition are define. This is just a continuation of zephyrproject-rtos#84195. Signed-off-by: Gerson Fernando Budke <[email protected]>
nandojve
added
the
Trivial
jfischer-no
removed
the
Trivial
I agreed that a fix is necessary and I open an issue to proper report but this is blocking a DMA fix #84118 which blocks a full RTC driver on #81819. I would like not to be penalize in this case. I don't mind to revert this changes as soon we have a fix. |
Nobody is getting penalized. If there is no immediate fix for the issue introduced by 1440f5c, we should revert it now. What this PR is doing is not correct and it does not scale in any way. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The dfu sample filter seems not to work. It should select only boards when
slot0_partitionandslot1_partitionare define. This is just a continuation of #84195. The issue is documented on #84196.This add all the sam0 boards in the exclusion list until the issue is fixed.