Renamed _Fault to z_${ARCH}_fault #84535
Open
+18
−18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The exception fault handler function is named _Fault which is inconsistent with all other arch-specific functions present in Zephyr. This patch replaces the name with z_arc_fault. Signed-off-by: Joel Holdsworth <[email protected]>
The exception fault handler function is named _Fault which is inconsistent with all other arch-specific functions present in Zephyr. This patch replaces the name with z_mips_fault. Signed-off-by: Joel Holdsworth <[email protected]>
zephyrbot
added
area: ARC
zephyrbot
requested review from
abrodkin,
carlocaione,
edersondisouza,
evgeniy-paltsev,
fkokosinski,
katsuster,
kgugala,
mgielda,
nashif,
npitre,
ruuddw,
tagunil,
tgorochowik and
ycsin
An existing comment references a function "irq_oflload()", which should be written "irq_offload()". This issue was detecte by the GitHub CI compliance check. Signed-off-by: Joel Holdsworth <[email protected]>
jhol
force-pushed
the
fault-handler-name
branch
from
3463433 to
331ddcf
Compare
|
v2 of the patch set adds a fix for a pre-existing typo that was picked up by the CI Compliance Check. |
The exception fault handler function is named _Fault which is inconsistent with all other arch-specific functions present in Zephyr. This patch replaces the name with z_nios2_fault. Signed-off-by: Joel Holdsworth <[email protected]>
The exception fault handler function is named _Fault which is inconsistent with all other arch-specific functions present in Zephyr. This patch replaces the name with z_riscv_fault. Signed-off-by: Joel Holdsworth <[email protected]>
jhol
force-pushed
the
fault-handler-name
branch
from
331ddcf to
80b862e
Compare
npitre
approved these changes
Jan 24, 2025
nashif
approved these changes
Jan 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During the development of the OpenRISC port of Zephyr, it was noticed that multiple architectures have common fatal exception handling code in a function named
_Fault. This name is inconsistent with all other functions defined in code for the various architectures.This PR proposes that these functions be renamed to
z_${ARCH}_faulti.e.z_arc_fault,z_mips_fault,z_nios2_faultandz_riscv_faultrespectively to improve consistency.