drivers: counter: Add MCP7940N property to enable VBAT backup #84536
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drivers/counter/rtc_mcp7940n.c
Outdated
| @@ -757,6 +762,7 @@ static DEVICE_API(counter, mcp7940n_api) = { | |||
| }, \ | |||
| .i2c = I2C_DT_SPEC_INST_GET(index), \ | |||
| .int_gpios = GPIO_DT_SPEC_INST_GET_OR(index, int_gpios, {0}), \ | |||
| .vbat_enable = DT_INST_PROP_OR(index, vbat_enable, false) \ | |||
There was a problem hiding this comment.
For booleans you can just use DT_INST_PROP(), it will always be defined to true or false
There was a problem hiding this comment.
I didn't know about it, thanks! Fixed
This PR adds a new devicetree property that allows enabling external battery backup functionality. Signed-off-by: Marcin Lyda <[email protected]>
Lefucjusz
force-pushed
the
add_mcp7940_vbat_enable_property
branch
from
09f5ab4 to
338b684
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new devicetree property that allows enabling external battery backup functionality.