logging: backend_fs: disable ANSI color for filesystem logging #84542
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before the fix for zephyrproject-rtos#77150 was merged, with LOG_BACKEND_SHOW_COLOR=n and CONFIG_SHELL_VT100_COLORS=y the shell would still display colors by enabling the flag in the shell_log_backend.c. Now, LOG_BACKEND_SHOW_COLOR has to be enabled to allow shell logging color, but that writes ANSI escape sequences to the log files. Explicitly disable ANSI color output for the filesystem logging backend. Signed-off-by: Eric Holmberg <[email protected]>
dcpleung
approved these changes
Jan 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Disable ANSI color output for the filesystem backend.
Previously with LOG_BACKEND_SHOW_COLOR=n and CONFIG_SHELL_VT100_COLORS=y the shell would still display colors by enabling the flag in the
shell_log_backend.c.See discussion in https://discord.com/channels/720317445772017664/1331905134703284274 for some context.