Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add metrics #4296

Closed
wants to merge 1 commit into from
Closed

add metrics #4296

wants to merge 1 commit into from

Conversation

sunshujie1990
Copy link

No description provided.

@sunshujie1990
Copy link
Author

Base on #3624
Add http server metric buckets.
@MarkJoyMa @kevwan

@kevwan kevwan requested a review from MarkJoyMa August 6, 2024 08:41
@MarkJoyMa
Copy link
Collaborator

MarkJoyMa commented Aug 11, 2024

We thought about it and found that buckets need a more general solution, because different business scenarios require different granularity for buckets. For example, gateway-type businesses need to distinguish at a finer granularity, and transaction order-type business scenarios may generally have longer request durations. Therefore, we need to support the ability for businesses to actively set buckets, so that buckets can be set according to their own situations in various business scenarios. Please wait for me to provide PR #4313.

@MarkJoyMa MarkJoyMa added the do-not-merge/hold Indicates that a PR should not merge because of known issues or need more discussion. label Aug 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge/hold Indicates that a PR should not merge because of known issues or need more discussion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants