-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Version 2 #15
base: main
Are you sure you want to change the base?
Version 2 #15
Conversation
CC @Koenkk |
Why the |
Without separators, it's hard to check individual octets. It's meant to be human-readable. Nice to have when checking IEEE prefixes/suffixes. |
I would argue it should be optimised for systems, not for humans. |
In ZHA, we allow backups to be downloaded at runtime so it's something people do often enough to even warrant the in-JSON comment about missing devices. My other use case is copy/pasting keys into Wireshark (which requires colons) and comparing them to log file IEEE and NWK addresses. We use colons in ZHA both in the frontend and when logging. I dunno, I personally feel the readability improvements heavily outweigh the two tiny functions required to format/unformat byte arrays. |
The colons fits the Wireshark pattern, but makes it harder to handle in REPL (to run quick tests) or even with editors like vscode (can't quick select the whole value). Definitely worse for devs. In general, I'm not a fan of the inconsistencies in storage for sequences of bytes, some are now plain, some are now |
We probably also should have zigbee groups in here, to provide a "fuller backup"? |
This is a slight iteration on what we currently use internally in zigpy.
CC @Nerivec