Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sparse: readd GetVectorByIds support for growing segments with IP metric #1022

Merged
merged 1 commit into from
Jan 10, 2025

Conversation

sparknack
Copy link
Contributor

No description provided.

Copy link

mergify bot commented Jan 10, 2025

@sparknack 🔍 Important: PR Classification Needed!

For efficient project management and a seamless review process, it's essential to classify your PR correctly. Here's how:

  1. If you're fixing a bug, label it as kind/bug.
  2. For small tweaks (less than 20 lines without altering any functionality), please use kind/improvement.
  3. Significant changes that don't modify existing functionalities should be tagged as kind/enhancement.
  4. Adjusting APIs or changing functionality? Go with kind/feature.

For any PR outside the kind/improvement category, ensure you link to the associated issue using the format: “issue: #”.

Thanks for your efforts and contribution to the community!.

@zhengbuqian
Copy link
Collaborator

zhengbuqian commented Jan 10, 2025

/kind improvement

@zhengbuqian
Copy link
Collaborator

/lgtm
/approve

@sre-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sparknack, zhengbuqian

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@zhengbuqian
Copy link
Collaborator

/kind improvement

Copy link

mergify bot commented Jan 10, 2025

@sparknack Please remove redundant kind/xxx labels and make sure that there is only one kind/xxx label of your Pull Request. (eg. “/remove-kind improvement”)

@zhengbuqian
Copy link
Collaborator

/remove-kind enhancehemt

@sre-ci-robot
Copy link
Collaborator

@zhengbuqian: Those labels are not set on the issue: kind/enhancehemt

In response to this:

/remove-kind enhancehemt

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@mergify mergify bot added the ci-passed label Jan 10, 2025
@sre-ci-robot sre-ci-robot merged commit a01d8ba into zilliztech:main Jan 10, 2025
10 of 11 checks passed
Copy link

codecov bot commented Jan 10, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.98%. Comparing base (3c46f4c) to head (c0946f9).
Report is 286 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##           main    #1022       +/-   ##
=========================================
+ Coverage      0   73.98%   +73.98%     
=========================================
  Files         0       82       +82     
  Lines         0     7011     +7011     
=========================================
+ Hits          0     5187     +5187     
- Misses        0     1824     +1824     

see 82 files with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants