Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove deprecated conan generator #174

Merged
merged 1 commit into from
Nov 9, 2023
Merged

Remove deprecated conan generator #174

merged 1 commit into from
Nov 9, 2023

Conversation

jiaoew1991
Copy link
Contributor

/kind improvement

@sre-ci-robot
Copy link
Collaborator

Welcome @jiaoew1991! It looks like this is your first PR to zilliztech/knowhere 🎉

@mergify mergify bot added the dco-passed label Nov 2, 2023
@jiaoew1991 jiaoew1991 force-pushed the fix-deprecated-generator2 branch 3 times, most recently from cd9a023 to ff7096c Compare November 3, 2023 17:25
@jiaoew1991 jiaoew1991 force-pushed the fix-deprecated-generator2 branch from ff7096c to 6ac6422 Compare November 7, 2023 16:27
@sre-ci-robot sre-ci-robot added size/S and removed size/M labels Nov 7, 2023
@jiaoew1991 jiaoew1991 force-pushed the fix-deprecated-generator2 branch 3 times, most recently from b63a983 to 16a9af1 Compare November 7, 2023 17:48
@mergify mergify bot added the ci-passed label Nov 7, 2023
@Presburger
Copy link
Collaborator

/lgtm

@liliu-z
Copy link
Collaborator

liliu-z commented Nov 9, 2023

/approve

@sre-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jiaoew1991, liliu-z

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit 6b2fe56 into zilliztech:main Nov 9, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cqy123456 cqy123456 Awaiting requested review from cqy123456

@cydrain cydrain Awaiting requested review from cydrain

Assignees

@Presburger Presburger

Labels
approved ci-passed dco-passed kind/improvement lgtm size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jiaoew1991 @sre-ci-robot @Presburger @liliu-z