-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove unused stats in PQFastScan #180
Conversation
Signed-off-by: chasingegg <[email protected]>
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: chasingegg The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/kind improvement |
@chasingegg Could you please elaborate why the failure can happen? Thanks |
We will get |
Also, as far I as remember, some of the veeeeeery recent commits to Faiss moved this stats from global to local variable, which is passed in a function. We can go this way as well. |
/lgtm |
Signed-off-by: chasingegg <[email protected]>
Signed-off-by: chasingegg <[email protected]>
Remove unused stats in PQFastScan, where milvus could fail on global variable initialization on an sse4_2 machine.