Add row number constraint for building scann index #185
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: chasingegg The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
cydrain
reviewed
Nov 8, 2023
src/index/ivf/ivf.cc
Outdated
| @@ -270,6 +270,12 @@ IvfIndexNode<T>::Train(const DataSet& dataset, const Config& cfg) { | |||
| auto dim = dataset.GetDim(); | |||
| auto data = dataset.GetTensor(); | |||
|
|
|||
| // faiss scann needs at least 16 rows | |||
| if (rows < 16 && std::is_same<faiss::IndexScaNN, T>::value) { | |||
There was a problem hiding this comment.
const int64_t SCANN_MIN_ROWS = 16;
if (std::is_same<faiss::IndexScaNN, T>::value) {
if (rows < SCANN_MIN_ROWS) {
.....
Signed-off-by: chasingegg <[email protected]>
chasingegg
force-pushed
the
fix-scann-row
branch
from
38922fe to
9dba0be
Compare
|
/lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #183
/kind bug
When people use milvus, index will not be built(brute force search) when rows < MinSegmentNumRowsToEnableIndex(1024), https://github.com/milvus-io/milvus/blob/master/internal/datacoord/index_builder.go#L237