Skip to content

Commit

Permalink
Merge pull request #315 from zillow/tz/remove-absl
Browse files Browse the repository at this point in the history
remove absl-py dependency
  • Loading branch information
talebzeghmi authored Sep 27, 2024
2 parents 64236a4 + 6220061 commit 025acf0
Show file tree
Hide file tree
Showing 4 changed files with 9 additions and 4 deletions.
4 changes: 3 additions & 1 deletion kfp/containers/entrypoint.py
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,9 @@

from typing import Dict, NamedTuple, Optional, Union

from absl import logging
# talebz: remove the need for absl by using logging instead
# from absl import logging
import logging
import fire
from google.protobuf import json_format
import os
Expand Down
4 changes: 3 additions & 1 deletion kfp/containers/entrypoint_utils.py
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,9 @@
# See the License for the specific language governing permissions and
# limitations under the License.

from absl import logging
# talebz: remove the need for absl by using logging instead
# from absl import logging
import logging
import importlib
import sys
from typing import Callable, Dict, Optional, Union
Expand Down
4 changes: 3 additions & 1 deletion kfp/dsl/artifact.py
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,9 @@

from typing import Any, Dict, Optional

from absl import logging
# talebz: remove the need for absl by using logging instead
# from absl import logging
import logging
import enum
import importlib
import jsonschema
Expand Down
1 change: 0 additions & 1 deletion setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,6 @@
"boto3",
"pylint",
# required for KFP
"absl-py>=0.9,<=0.11",
"Deprecated>=1.2.7,<2",
"docstring-parser>=0.7.3,<1",
"fire>=0.3.1,<1",
Expand Down

0 comments on commit 025acf0

Please sign in to comment.