Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature/kfp-argo #254

Closed
wants to merge 13 commits into from
Closed

feature/kfp-argo #254

wants to merge 13 commits into from

Conversation

talebzeghmi
Copy link
Collaborator

No description provided.

talebzeghmi and others added 13 commits May 17, 2023 14:31
* AIP-7299 kfp run to use Argo submit

* serviceAccoutName default-editor

* ignore flow_triggering_flow.py test

* PR Feedback

* Unit test fix
* AIP-7314 Argo Flow Trigger Flow

* PR Feedback
* AIP-7339 first checkin

* PR Feedback

* CronWorkflow parameters

* Merge fixes

* integration test fixes

* only print `argo watch` if `argo` is in the path

* --pipeline-name parameter

* KFP_ARGO_COMPILE_WORKFLOW_ONLY feature (#241)

* AIP-7535 cleanup creating Argo YAML (#250)

* AIP-7535 cleanup creating Argo YAML

* PR Feedback

* AIP-7540 Argo Parameters (#249)

* AIP-7540 Argo Parameters

* Fix for JSON parameters

* Fix exit_handler Argo failure with no Flow params

* exit handler workflow.parameters quotes

* PR Feedback

* PR Feedback
- inline {{workflow.parameters}} as FLOW_PARAMETERS_JSON
- cleanup kfp.deploy()
* AIP-7339 parameterize name of CronWorkflow and ConfigMap

* use --name for ConfigMap synchronization reference

* Flow Parameters in CronWorkflow

* CronWorkflow compiled arguments on workflowSpec fix
* AIP-7418 Remove KFP create

* AIP-7385 rename KFP to AIP plugin (#258)

* AIP-7385 rename KFP to AIP plugin

* friendly error message for "kfp run"

* AIP-7393 Add Flow labels to Workflow for ArgoUI (#259)

* AIP-7393 Add Flow labels to Workflow for ArgoUI

* PR feedback

* AIP-7726 add default cards (#260)

* AIP-7726 add default cards

* param fix

* PR feedback
- comment archive none
- add card id to support current.card.append()
- add example of notebook card & multiple cards

* aip.zillowgroup.net/aip-pod-default -> aip.zillowgroup.net/aip-wfsdk-pod

* logging.zgtools.net/index -> logging.zgtools.net/topic

* fix card pathspec for nested foreach

* fix github test.yml branches

* resources_flow.py label fixes

* PR Feedback

* update test.yml

* AIP-7773 argo flow trigger flow (#261)
* AIP-7784 validate MF tags w/ k8s label rules
- AIP-7393 Add Flow labels to Workflow for ArgoUI #259 #259 introduced this bug where AIP flow tags become k8s labels and hence need the same k8s label value validation.

* add unit tests

* uncomment commented out test
* AIP-7802 WFSDK v2 for kfp-argo

* use CICD v4 ref

* pin docker image
* AIP-7796 Embed zillow-kfp compiler into WFSDK

* jsonschema>=4.19.2,<5

* remove incorrect package exclude
@talebzeghmi talebzeghmi closed this Nov 1, 2023
@talebzeghmi
Copy link
Collaborator Author

closing this in favor of #269 to merge into feature/aip

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant