Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AIP-7738 retry_backoff_factor feature #264

Merged
merged 2 commits into from
Oct 17, 2023
Merged

AIP-7738 retry_backoff_factor feature #264

merged 2 commits into from
Oct 17, 2023

Conversation

talebzeghmi
Copy link
Collaborator

  • change the default
    • minutes_between_retries = 2m
    • RETRY_BACKOFF_FACTOR = 3
    • 2 * 3 * 3 * 3 = 54 minutes
  • this would give flows more time to be resilient for transient cluster failures. note: If we believe that this should be more configurable, then the default retry strategy could be applied by the webhook.

@talebzeghmi
AIP-7738 retry_backoff_factor feature
7dfdeb6 
- change the default
  - minutes_between_retries = 2m
  - RETRY_BACKOFF_FACTOR = 3
  - 2 * 3 * 3 * 3 = 54 minutes
- this would give flows more time to be resilient for transient cluster failures.
note: If we believe that this should be more configurable, then the default retry strategy could be applied by the webhook.
@talebzeghmi talebzeghmi merged commit 22c3f21 into feature/kfp Oct 17, 2023
@talebzeghmi talebzeghmi deleted the tz/AIP-7738-exp-backoff branch October 17, 2023 22:53
@talebzeghmi talebzeghmi mentioned this pull request Oct 31, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cloudw cloudw cloudw approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@talebzeghmi @cloudw