Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AIP-8051 Fix AIP Integration tests #281

Merged
merged 5 commits into from
Jan 31, 2024
Merged

AIP-8051 Fix AIP Integration tests #281

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
740c233
AIP-8051 Fix AIP Integration tests
talebzeghmi Jan 30, 2024
4a51c48
pin black check
talebzeghmi Jan 30, 2024
baa6259
pin click<8.1.0
talebzeghmi Jan 30, 2024
2b47cc4
pin tox==3.25.1
talebzeghmi Jan 30, 2024
0cbb9ac
DEPLOY_STAGE
talebzeghmi Jan 31, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ jobs:
- name: Install Python ${{ matrix.ver }} dependencies
run: |
python3 -m pip install --upgrade pip setuptools
python3 -m pip install tox numpy black
python3 -m pip install tox==3.25.1 numpy black==21.12b "click<8.1.0"

- name: Python Code Format Check
run: black --target-version py39 --diff --check ./metaflow/plugins/aip/*.py
4 changes: 2 additions & 2 deletions .gitlab-ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ variables:
# Run on the Internal cluster only on commit.
# We run the tests via the integration test framework for Non-Prod/Prod.
DEPLOY_INTERNAL: "true"
DEPLOY_NONPROD: "false"
DEPLOY_STAGE: "false"
DEPLOY_PROD: "false"
DEPLOY_SANDBOX: "false"
PUBLISH: "true"
Expand Down Expand Up @@ -172,7 +172,7 @@ test:nonprod:
METAFLOW_RUN_URL_PREFIX: "https://metaflow.int.stage-k8s.zg-aip.net"
METAFLOW_KUBERNETES_NAMESPACE: "metaflow-integration-testing-stage"
rules:
- if: '$DEPLOY_NONPROD == "true"'
- if: '$DEPLOY_STAGE == "true"'

test:prod:
extends:
Expand Down
Loading