AIP-8072 set retry "2m" not 2 #284
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cloudw
approved these changes
Feb 8, 2024
| is_number = isinstance(val, numbers.Number) or ( | ||
| isinstance(val, str) and val.isdecimal() | ||
| ) | ||
| return f"{val}m" if is_number else val |
There was a problem hiding this comment.
Hmm do we want to wait for 2 mins all the time? Just thinking how much time that'd potentially add to the integration test runs. Is there a way to be smarter here and use an exponential backoff?
Edit: To clarify I think this change given it's for the _get_mins_between_retries isn't the issue, this fix is good and should stay. But for the integration tests it'd be nice for those to run as quickly as possible, not sure what that means in terms of potential changes.
There was a problem hiding this comment.
Thanks for bringing this up!
I set --with retry:minutes_between_retries=0 and @retry(minutes_between_retries=0) for integration tests!
talebzeghmi
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is concerning because the default retry was
2seconds between retries!