Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AIP-8434 resilient_flow.py fix #297

Merged
merged 1 commit into from
May 21, 2024
Merged

AIP-8434 resilient_flow.py fix #297

merged 1 commit into from
May 21, 2024

Conversation

talebzeghmi
Copy link
Collaborator

  • WFSDK resilient_flow.py to handle DEFAULT_REQUEUE_TIME=1m
  • The manner in which resilient_flow.py tests resiliency is by a hard kubectl pod delete immediately when the start step begins. This does not allow the argo-wf-controller time (1m) to even know that the pod has started, and hence attempts to start the step again and again.

@talebzeghmi
AIP-8434 resilient_flow.py fix
31425c0 
- WFSDK resilient_flow.py to handle DEFAULT_REQUEUE_TIME=1m
- The manner in which resilient_flow.py tests resiliency is by a hard kubectl pod delete immediately when the start step begins.  This does not allow the argo-wf-controller time (1m) to even know that the pod has started, and hence attempts to start the step again and again.
@talebzeghmi talebzeghmi requested a review from cloudw May 21, 2024 22:36
@talebzeghmi talebzeghmi merged commit b4c3270 into feature/aip May 21, 2024
4 checks passed
@talebzeghmi talebzeghmi deleted the tz/AIP-8434-resilient_flow_fix branch May 21, 2024 23:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cloudw cloudw cloudw approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@talebzeghmi @cloudw