Avoid exhausting type ids due to transaction rollbacks #435
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lvonk
reviewed
Dec 20, 2024
erikrozendaal
force-pushed
the
avoid-exhausting-type-ids
branch
3 times, most recently
from
3bdf5c8 to
e3e1b3e
Compare
Type ids (for aggregate, command, and event types) use the `SMALLINT` data type to optimize storage usage. However, when a sequence is used to generated ids the ids can be dropped on transaction rollback. This can cause the ids to be quickly exhausted when something is misconfigured. This change uses the highest id + 1 for the next id. This is slow and requires table locking, but since new types are rarely added this should not impact normal performance.
Note that updating the type tables is a very rare occurence (only when new code is deployed and the new types are committed to the event store) so locking these tables should not be a performance bottleneck in the normal case.
erikrozendaal
force-pushed
the
avoid-exhausting-type-ids
branch
from
e3e1b3e to
217e61d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type ids (for aggregate, command, and event types) use the
SMALLINTdata type to optimize storage usage. However, when a sequence is used to generated ids the ids can be dropped on transaction rollback. This can cause the ids to be quickly exhausted when something is misconfigured.This change uses the highest id + 1 for the next id. This is slow and requires table locking, but since new types are rarely added this should not impact normal performance.