Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enforce user defined unique keys for aggregates #437

Merged
merged 15 commits into from
Jan 16, 2025
Merged

Enforce user defined unique keys for aggregates #437

merged 15 commits into from
Jan 16, 2025

Conversation

erikrozendaal
Copy link
Member

@erikrozendaal erikrozendaal commented Dec 24, 2024 •
edited
Loading

TODO:

  • DSL for defining unique keys
  • More tests
  • Documentation
  • Changelog
  • Database migration

@erikrozendaal erikrozendaal force-pushed the aggregate-unique-keys branch 2 times, most recently from 91901ac to 545d7f1 Compare January 6, 2025 10:51
lvonk
lvonk reviewed Jan 7, 2025
View reviewed changes
Copy link
Member

@lvonk lvonk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a really nice addition. I do prefer a more descriptive style (like ActiveRecord does) for the implementation. This also gives us more flexibility whenever we decide to for instance implement storing these keys differently.

lib/sequent/core/aggregate_root.rb Outdated Show resolved Hide resolved
lib/sequent/core/event_store.rb Outdated Show resolved Hide resolved
@erikrozendaal
Enforce user defined unique keys for aggregates
194c8b0
@erikrozendaal
Move AggregateKeyNotUniqueError to Sequent::Core namespace
7d4b194
@erikrozendaal
Update command helpers to enforce unique keys in domain tests
758a514
@erikrozendaal
Delete removed unique keys before inserting new ones
4f7a01e 
This allows moving a unique key from one aggregate to another in a
single atomic transaction.
@erikrozendaal
Test moving of unique keys from one aggregate to another
7a3adb6
@erikrozendaal
Support using the real event store with the command testing DSL
3ea0ccb 
Unifies the real and fake event store APIs so the same testing
DSL (`given_events`, `when_command`, `then_events`) can be used with
both event stores.

Test correct support for aggregate unique keys using this testing DSL.
@erikrozendaal
Add DSL for defining unique keys
f84b8ea
@erikrozendaal
Rework unique key DSL to allow blocks for calculating key values
77a31f3
@erikrozendaal
Include aggregate type and id in unique key violation error message
05b8eac
@erikrozendaal
Reload aggregates from existing and new events in fake event store
00dc3c3
@erikrozendaal
Add stored_events helper to retrieve events since last command
bf53e0f 
Mark the position in the event store when executing a command. The
`stored_event` and `then_events` helpers retrieve and compare the
events stored since the last command execution.
@erikrozendaal
Allow using RSpec matchers when testing events
98c519e
@erikrozendaal
Update CHANGELOG
a4a6790
@erikrozendaal erikrozendaal requested a review from lvonk January 15, 2025 14:13
@erikrozendaal erikrozendaal marked this pull request as ready for review January 16, 2025 14:30
@erikrozendaal erikrozendaal merged commit a7abf4d into master Jan 16, 2025
7 checks passed
@erikrozendaal erikrozendaal deleted the aggregate-unique-keys branch January 16, 2025 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mvandiepen mvandiepen Awaiting requested review from mvandiepen

@lvonk lvonk Awaiting requested review from lvonk

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@erikrozendaal @lvonk